robur/builder-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed debug-printing + Adjusted size of treemap iframe

Browse source
This commit is contained in:
rand00 2021-12-15 21:32:41 +01:00 committed by Reynir Björnsson
parent 07b5daff9f
commit 6a70220dee
2 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/builder_web.ml
View file

@ -184,7 +184,6 @@ let add_routes datadir =
in in
let job_build_treemap req = let job_build_treemap req =
Log.info (fun m -> m ">>>>>>>>>> entering job_build_treemap");
let _job_name = Dream.param "job" req let _job_name = Dream.param "job" req
and build = Dream.param "build" req in and build = Dream.param "build" req in
get_uuid build >>= fun uuid -> get_uuid build >>= fun uuid ->
@ -201,7 +200,6 @@ let add_routes datadir =
|> if_error "Error getting job build" |> if_error "Error getting job build"
~log:(fun e -> Log.warn (fun m -> m "Error getting job build: %a" pp_error e)) ~log:(fun e -> Log.warn (fun m -> m "Error getting job build: %a" pp_error e))
>>= fun (debug_binary, main_binary) -> >>= fun (debug_binary, main_binary) ->
Log.info (fun m -> m ">>>>>>>>>> binary + debug-binary bound");
let binary_size = main_binary.Builder_db.size in let binary_size = main_binary.Builder_db.size in
let datadir = Dream.global datadir_global req in let datadir = Dream.global datadir_global req in
let path = Fpath.(datadir // debug_binary.Builder_db.localpath) in let path = Fpath.(datadir // debug_binary.Builder_db.localpath) in
@ -213,7 +211,6 @@ let add_routes datadir =
~log:(fun _ -> Log.warn (fun m -> ~log:(fun _ -> Log.warn (fun m ->
m "Error reading ELF file %a" Fpath.pp path)) m "Error reading ELF file %a" Fpath.pp path))
>>= fun infos -> >>= fun infos ->
Log.info (fun m -> m ">>>>>>>>>> infos bound");
let svg_html = let svg_html =
infos infos
|> Info.import |> Info.import
@ -227,7 +224,6 @@ let add_routes datadir =
* |> Fmt.to_to_string (Tyxml.Svg.pp ()) *) * |> Fmt.to_to_string (Tyxml.Svg.pp ()) *)
in in
(* Lwt_result.ok (dream_svg svg) *) (* Lwt_result.ok (dream_svg svg) *)
Log.info (fun m -> m ">>>>>>>>>> returning svg_html");
Lwt_result.ok (Dream.html svg_html) Lwt_result.ok (Dream.html svg_html)
in in

2
lib/views.ml
View file

@ -359,7 +359,7 @@ let job_build
h3 [txt "Analysis"]; h3 [txt "Analysis"];
p [ p [
let src = Fmt.str "/job/%s/build/%a/treemap" name Uuidm.pp uuid in let src = Fmt.str "/job/%s/build/%a/treemap" name Uuidm.pp uuid in
let style = "width: 50em; height: 50.5em" in (*treemap tries to be square*) let style = "width: 50em; height: 53.0em" in (*treemap tries to be square*)
iframe ~a:[ a_src src; a_title "Binary dissection"; a_style style ] [] ]; iframe ~a:[ a_src src; a_title "Binary dissection"; a_style style ] [] ];
h3 [txt "Build info"]; h3 [txt "Build info"];
ul [ ul [