From dd5549113878f82e56dbae14c0783852932054d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Reynir=20Bj=C3=B6rnsson?= <reynir@reynir.dk>
Date: Tue, 22 Dec 2020 13:45:54 +0100
Subject: [PATCH] Document assumption

---
 lib/builder_web.ml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/builder_web.ml b/lib/builder_web.ml
index 25f4830..75e268e 100644
--- a/lib/builder_web.ml
+++ b/lib/builder_web.ml
@@ -64,6 +64,9 @@ let routes (t : Model.t) =
     let job = Router.param req "job"
     and run = Router.param req "run"
     and file = Router.splat req |> String.concat "/" in
+    (* XXX: We don't check safety of [file]. This should be fine however since
+     * we don't use [file] for the filesystem but is instead used as a key for
+     * lookup in the data table of the 'full' file. *)
     match safe_seg job, safe_seg run, Fpath.of_string file with
     | Error (`Msg e), _, _ | _, Error (`Msg e), _ | _, _, Error (`Msg e) ->
       Log.debug (fun m -> m "bad path: %s" e);