robur/git-kv
4
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Document change_and_push_waiter details

Browse source
This commit is contained in:
Reynir Björnsson 2024-10-29 10:10:17 +01:00
parent 750ec11b5f
commit 9afb8e29e2
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/git_kv.ml
View file

@ -679,7 +679,11 @@ module Make (Pclock : Mirage_clock.PCLOCK) = struct
| None -> | None ->
(* XXX(dinosaure): serialize [change_and_push]. If we do (* XXX(dinosaure): serialize [change_and_push]. If we do
[Lwt.both (change_and_push ..) (change_and_push ..)], they can not run [Lwt.both (change_and_push ..) (change_and_push ..)], they can not run
concurrently! The second will waiting the first to finish. *) concurrently! The second will waiting the first to finish.
(reynir): Furthermore, we need to create a new task and update
[change_and_push_waiter] before we wait on the existing
[change_and_push_waiter] task without any yield point in between to
ensure serializability. *)
let th, wk = Lwt.wait () in let th, wk = Lwt.wait () in
let th' = t.change_and_push_waiter in let th' = t.change_and_push_waiter in
t.change_and_push_waiter <- Some th; t.change_and_push_waiter <- Some th;