robur/git-kv
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

last_modified: don't find_blob; find the commit! #10

Merged
reynir merged 2 commits from fix-last_modified into main 2024-12-20 12:11:32 +00:00
Conversation 0 Commits 2 Files changed 1 +21 -20
1 changed files with 21 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d2a0e526da - Show all commits

7
src/git_kv.ml
View file

@ -472,8 +472,10 @@ module Make (Pclock : Mirage_clock.PCLOCK) = struct
~none:Ptime.epoch
~some:Fun.id (Ptime.of_float_s (Int64.to_float (now ()))))
| None, Some head ->
Store.read_exn t.store head >|= function
| Commit c ->
(* See https://github.com/ocaml/ocaml/issues/9301 why we have the
intermediate [r] value. *)
let+ r = Store.read_exn t.store head in
let[@warning "-8"] Commit c = r in
let author = Git_commit.author c in
let secs, tz_offset = author.Git.User.date in
let secs =
@ -491,7 +493,6 @@ module Make (Pclock : Mirage_clock.PCLOCK) = struct
~some:Fun.id (Ptime.of_float_s (Int64.to_float secs))
in
hannes marked this conversation as resolved Outdated
hannes commented 2024-12-18 15:57:36 +00:00
Outdated
Review
Copy link

this case shouldn't be needed

this case shouldn't be needed
reynir commented 2024-12-19 13:36:46 +00:00
Outdated
Review
Copy link

What do you suggest instead? Mute partial match warnings?

let [@warning "-8"] (`Commit c) = Store.read_exn .. in
..
What do you suggest instead? Mute partial match warnings? ```OCaml let [@warning "-8"] (`Commit c) = Store.read_exn .. in .. ```
hannes commented 2024-12-19 13:46:27 +00:00
Outdated
Review
Copy link

yes, as done in let pull

yes, as done in `let pull`
👍 1
reynir commented 2024-12-19 14:13:35 +00:00
Outdated
Review
Copy link

This is done in d2a0e526da. I found that there's no support for infix attributes on binding operators (.e.g let+) so I went with an intermediate binding.

https://github.com/ocaml/ocaml/issues/9301

This is done in d2a0e526dad259f71fc7f741129aba8e476c8f7a. I found that there's no support for infix attributes on binding operators (.e.g `let+`) so I went with an intermediate binding. https://github.com/ocaml/ocaml/issues/9301
Ok ts
| _ -> assert false
let digest t key =
let open Lwt.Infix in