robur/http-mirage-client
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add a comment into the HTTP_client device to explain why the Git word appears

Browse source
This commit is contained in:
Romain Calascibetta 2022-10-17 15:15:02 +02:00
parent 546a06441c
commit b707beed78
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
README.md
View file

@ -37,6 +37,10 @@ let dns = generic_dns_client stack
let tcp = tcpv4v6_of_stackv4v6 stack let tcp = tcpv4v6_of_stackv4v6 stack
let http_client = let http_client =
(* XXX(dinosaure): it seems unconventional to use [git_happy_eyeballs] here
when we want to do HTTP requests only. The name was not so good and we
will fix that into the next release of the mirage tool. But structurally,
you don't bring anything related to Git. It's just a bad choice of name. *)
let happy_eyeballs = git_happy_eyeballs stack dns let happy_eyeballs = git_happy_eyeballs stack dns
(generic_happy_eyeballs stack dns) in (generic_happy_eyeballs stack dns) in
http_client $ default_posix_clock $ tcp $ happy_eyeballs http_client $ default_posix_clock $ tcp $ happy_eyeballs