At startup, always check the digests of the files

hannes commented

2024-11-13 12:19:44 +00:00

Owner

we should do this, maybe in the background -- so the startup should be:

try to get the git archive / index.tar.gz up and running (if not, do the git clone)
start the webserver
start the git pull (unless already done in the first step)
check the hashes of the archive, potentially moving data elsewhere
allow access to the tarballs that have been checked
download of needed tarballs

I find the "bringing up the web service" should be the highest priority, but delivering archives with bad checksums is something that we should really avoid.

Currently, we have a --verify-sha256 flag which is off by default and only if it is true, the archive checksums are verified (and this is done before the web server is up and running).

we should do this, maybe in the background -- so the startup should be: - try to get the git archive / index.tar.gz up and running (if not, do the git clone) - start the webserver - start the git pull (unless already done in the first step) - check the hashes of the archive, potentially moving data elsewhere - allow access to the tarballs that have been checked - download of needed tarballs I find the "bringing up the web service" should be the highest priority, but delivering archives with bad checksums is something that we should really avoid. Currently, we have a `--verify-sha256` flag which is off by default and only if it is true, the archive checksums are verified (and this is done before the web server is up and running).

dinosaure commented

2024-11-13 12:25:16 +00:00

Owner

Note that we don't need to check values into the git archive. The PACK file has a signature (a SHA1) which verify the integrity of the whole Git archive.