robur/opam-mirror
4
0
Fork 0
Code Issues 6 Pull requests 2 Projects Releases Packages Wiki Activity Actions

Remove unnecessary complexity #2

Merged
hannes merged 1 commit from opam-checksums into main 2024-10-03 22:10:09 +00:00
Conversation 1 Commits 1 Files changed 1 +4 -67
reynir commented 2024-10-03 16:15:06 +00:00
Owner
Copy link

Opam 2 only supports md5, sha256 and sha512. We don't need the extra
complexity of other hash algorithms. Opam 2 will fail to parse such an
opam file anyway.

It's specified in the opam manual, and I verified by asking on the #opam discord where Kate confirmed this was the case. It sounds like it's going to be the case at least until opam 3.

Opam 2 only supports md5, sha256 and sha512. We don't need the extra complexity of other hash algorithms. Opam 2 will fail to parse such an opam file anyway. It's specified in the [opam manual][opam-manual], and I verified by asking on the #opam discord where Kate confirmed this was the case. It sounds like it's going to be the case at least until opam 3. [opam-manual]: https://opam.ocaml.org/doc/Manual.html#Checksums
reynir added 1 commit 2024-10-03 16:15:06 +00:00 
Opam 2 only supports md5, sha256 and sha512. We don't need the extra
complexity of other hash algorithms. Opam 2 will fail to parse such an
opam file anyway.
hannes commented 2024-10-03 22:09:59 +00:00
Owner
Copy link

looks good to me, thanks!

looks good to me, thanks!
hannes merged commit 534292ec3f into main 2024-10-03 22:10:09 +00:00
hannes deleted branch opam-checksums 2024-10-03 22:10:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/opam-mirror#2
No description provided.
Delete branch "opam-checksums"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?