robur/opam-mirror
4
0
Fork 0
Code Issues 6 Pull requests 2 Projects Releases Packages Wiki Activity Actions

specify sizes of partitions in MB, not in sectors #27

Merged
reynir merged 1 commit from specify-in-mb into main 2024-11-21 11:27:41 +00:00
Conversation 2 Commits 1 Files changed 2 +30 -20
hannes commented 2024-11-21 11:12:29 +00:00
Owner
Copy link

//cc @reynir

//cc @reynir
hannes added 1 commit 2024-11-21 11:12:30 +00:00
hannes commented 2024-11-21 11:19:33 +00:00
Author
Owner
Copy link

I don't recall why we used sectors in the first place. I know that nowadays the sector_size is configurable, and it is much more convenient to specify sizes in terms of MB.

I don't recall why we used sectors in the first place. I know that nowadays the sector_size is configurable, and it is much more convenient to specify sizes in terms of MB.
reynir approved these changes 2024-11-21 11:25:14 +00:00
reynir commented 2024-11-21 11:27:31 +00:00
Owner
Copy link

I used sectors because I didn't want to deal with rounding and potential overflow. I think with realistic disk sizes we don't have to worry about overflow thankfully.

I used sectors because I didn't want to deal with rounding and potential overflow. I think with realistic disk sizes we don't have to worry about overflow thankfully.
reynir merged commit 2c606dbeb4 into main 2024-11-21 11:27:41 +00:00
reynir deleted branch specify-in-mb 2024-11-21 11:27:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
reynir
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/opam-mirror#27
No description provided.
Delete branch "specify-in-mb"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?