Reynir Björnsson reynir · he/him/his
  • Joined on 2024-08-21
reynir deleted branch batch-test from robur/git-kv 2024-10-29 11:21:19 +00:00
reynir merged pull request robur/git-kv#2 2024-10-29 11:21:16 +00:00
Refactor test/dune and add a failing test
reynir pushed to gh-pages at robur/blog.robur.coop 2024-10-29 11:19:27 +00:00
54cb3054e7 Pushed by YOCaml 2 from e993307d83
reynir pushed to gh-pages at robur/blog.robur.coop 2024-10-29 11:15:15 +00:00
5118161413 Pushed by YOCaml 2 from e993307d83
reynir deleted branch gptar-update from robur/blog.robur.coop 2024-10-29 11:12:10 +00:00
reynir merged pull request robur/blog.robur.coop#22 2024-10-29 11:12:08 +00:00
Add "GPTar update" article
reynir pushed to main at robur/blog.robur.coop 2024-10-29 11:12:08 +00:00
e993307d83 Merge pull request 'Add "GPTar update" article' (#22) from gptar-update into main
c2aeb492ec gptar-update.md: Add shell language
0aadded352 gptar-update.md: add tags, author
2228432cab Add "GPTar update" article
Compare 4 commits »
reynir commented on pull request robur/git-kv#2 2024-10-29 10:19:16 +00:00
Refactor test/dune and add a failing test

Could this be done with the mutex only instead of a bool, mutex and a condition?

reynir commented on pull request robur/git-kv#2 2024-10-29 09:51:27 +00:00
Refactor test/dune and add a failing test

I pushed the test, and found a fix... we were in the teardown of the change_and_push unconditionally setting t.change_and_push_waiter to None -- I now use (physical!) equality of th ==…

reynir pushed to batch-test at robur/git-kv 2024-10-29 09:51:27 +00:00
51e30538f6 Remove code! We don't need to update the waiter
reynir commented on pull request robur/git-kv#2 2024-10-29 09:38:16 +00:00
Refactor test/dune and add a failing test

Hmm. Would you mind pushing that test?

reynir commented on pull request robur/git-kv#3 2024-10-29 09:30:56 +00:00
only use a single commit in rename

Should we keep this comment?

reynir commented on pull request robur/git-kv#3 2024-10-29 09:30:56 +00:00
only use a single commit in rename

I thought "why not unconditionally do change_and_push?" and the answer is we disallow nested change_and_push and this is how we check if we're inside a change_and_push.

reynir commented on pull request robur/git-kv#3 2024-10-29 09:20:26 +00:00
only use a single commit in rename

should this be `

reynir commented on issue robur/blog.robur.coop#24 2024-10-29 09:18:16 +00:00
tags: improvements cleanups

I think some normalization would be very nice.

To my surprise the persistent storage tags works as is even though it has a space. I thought it would be more strict: https://blog.robur.coop/tag

reynir commented on pull request robur/git-kv#2 2024-10-29 09:13:26 +00:00
Refactor test/dune and add a failing test

I added a comment in the code to clarify this. It may not be evident from the code that there must not be any yield point there.

An observation I made is we can drop the option from the…

reynir pushed to batch-test at robur/git-kv 2024-10-29 09:10:44 +00:00
9afb8e29e2 Document change_and_push_waiter details
reynir pushed to gptar-update at robur/blog.robur.coop 2024-10-29 08:22:00 +00:00
c2aeb492ec gptar-update.md: Add shell language
reynir pushed to gptar-update at robur/blog.robur.coop 2024-10-29 08:05:37 +00:00
0aadded352 gptar-update.md: add tags, author
reynir created pull request robur/blog.robur.coop#23 2024-10-28 15:41:29 +00:00
Fix inadvertent double slash