tags: improvements cleanups #24

New issue

Open

opened 2024-10-28 17:45:23 +00:00 by hannes · 1 comment

hannes commented

2024-10-28 17:45:23 +00:00

Owner

from @reynir in #4 (comment)

I think it would be good to address the tag url and fragment issue mentioned. That is, we should instead of#tag-{{ tag.name }} do some processing of tag.name to make sure we have a string that works nicely as a fragment/element id. For now, I think all of the tags work fine without processing so it's perhaps not urgent, but it would be a shame to break URLs later. Second, the links to the tags are now computed in the templates, but I don't think the logic belongs there.

I also think we may want to lowercase the tags, otherwise different writings (OCaml, ocaml, Ocaml) lead to different tags? But I'm not certain about that -- maybe a check of the tag set that there's no case-insensitive-equal would be fine?

from @reynir in https://git.robur.coop/robur/blog.robur.coop/pulls/4#issuecomment-135 > I think it would be good to address the tag url and fragment issue mentioned. That is, we should instead of#tag-{{ tag.name }} do some processing of tag.name to make sure we have a string that works nicely as a fragment/element id. For now, I think all of the tags work fine without processing so it's perhaps not urgent, but it would be a shame to break URLs later. Second, the links to the tags are now computed in the templates, but I don't think the logic belongs there. I also think we may want to lowercase the tags, otherwise different writings (OCaml, ocaml, Ocaml) lead to different tags? But I'm not certain about that -- maybe a check of the tag set that there's no case-insensitive-equal would be fine?

👍 1

reynir commented

2024-10-29 09:18:16 +00:00

Owner

I think some normalization would be very nice.

To my surprise the persistent storage tags works as is even though it has a space. I thought it would be more strict: https://blog.robur.coop/tags.html#tag-persistent%20storage

I think some normalization would be very nice. To my surprise the `persistent storage` tags works as is even though it has a space. I thought it would be more strict: https://blog.robur.coop/tags.html#tag-persistent%20storage

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/blog.robur.coop#24

No description provided.