robur/blog.robur.coop

Fork 1

Implement tags #4

Merged

reynir merged 3 commits from yocaml2-tags into main

2024-10-16 09:45:47 +00:00

reynir commented

2024-10-09 09:54:34 +00:00

Owner

All tags are now on a single page. This is easier to implement with yocaml2's architecture.

The tag urls should probably be computed in blog.ml instead of in the templates, and the anchor fragments should be made url safe.

It could also be nice with some CSS to highlight the tag in focus on tags.html#tag-mytag.

All tags are now on a single page. This is easier to implement with yocaml2's architecture. The tag urls should probably be computed in blog.ml instead of in the templates, and the anchor fragments should be made url safe. It could also be nice with some CSS to highlight the tag in focus on `tags.html#tag-mytag`.

reynir added 1 commit 2024-10-09 09:54:35 +00:00

Implement tags 3b1d9f0805

All tags are now on a single page. This is easier to implement with
yocaml2's architecture.

reynir commented

2024-10-09 09:55:53 +00:00

Author

Owner

I spent quite some time trying to figure out how to generate tags/mytag.html and I'm not sure it fits well into yocaml2's model. IMO this works fine especially with some CSS tweaks.

I spent quite some time trying to figure out how to generate `tags/mytag.html` and I'm not sure it fits well into yocaml2's model. IMO this works fine especially with some CSS tweaks.

reynir added 1 commit 2024-10-09 10:08:14 +00:00

css: highlight targeted tag-box 6c79caeb19

reynir added 1 commit 2024-10-09 10:10:19 +00:00

css: ok, it looks better with background-color higlighting 90fc53c8d2

hannes commented

2024-10-15 19:34:53 +00:00

Owner

should this be merged? I'm not sure what the status is, maybe @dinosaure has time for a review?

reynir commented

2024-10-16 08:01:38 +00:00

Author

Owner

TL;DR: this can be merged, but it would be nice to address some issues.

I think it would be good to address the tag url and fragment issue mentioned. That is, we should instead of#tag-{{ tag.name }} do some processing of tag.name to make sure we have a string that works nicely as a fragment/element id. For now, I think all of the tags work fine without processing so it's perhaps not urgent, but it would be a shame to break URLs later. Second, the links to the tags are now computed in the templates, but I don't think the logic belongs there.

TL;DR: this can be merged, but it would be nice to address some issues. I think it would be good to address the tag url and fragment issue mentioned. That is, we should instead of`#tag-{{ tag.name }}` do some processing of `tag.name` to make sure we have a string that works nicely as a fragment/element id. For now, I think all of the tags work fine without processing so it's perhaps not urgent, but it would be a shame to break URLs later. Second, the links to the tags are now computed in the templates, but I don't think the logic belongs there.

hannes commented

2024-10-16 08:39:38 +00:00

Owner

processing the tag names, I'd take the approach that we restrict tags to whatever is fine for HTML (though it feels a bit sad to not have a 🎉 tag ;)

about where the logic resides: I've no opinion on that.

on the pragmatic side, I'm keen to get the tags back and our blog up to speed :)

processing the tag names, I'd take the approach that we restrict tags to whatever is fine for HTML (though it feels a bit sad to not have a 🎉 tag ;) about where the logic resides: I've no opinion on that. on the pragmatic side, I'm keen to get the tags back and our blog up to speed :)

reynir merged commit 33ef4926e2 into main

2024-10-16 09:45:47 +00:00

reynir deleted branch yocaml2-tags

2024-10-16 09:45:47 +00:00

reynir referenced this pull request from a commit

2024-10-16 09:45:49 +00:00

Merge pull request 'Implement tags' (#4) from yocaml2-tags into main

reynir commented

2024-10-16 09:54:13 +00:00

Author

Owner

I merged and deployed 890055c942

Unfortunately, some things broke /o\

Notably, [these][^footnotes] broke (new to me), and in the title we no longer have a dash like in Robur's blog - MirageVPN and OpenVPN but instead we have Robur's blogMirageVPN and OpenVPN (I noticed before, but forgot about it). I'll look into the former.

I merged and deployed https://git.robur.coop/robur/blog.robur.coop/commit/890055c942d6c8f713737fafcc04e434f672c622 Unfortunately, some things broke /o\ Notably, `[these][^footnotes]` broke (new to me), and in the title we no longer have a dash like in ` Robur's blog - MirageVPN and OpenVPN` but instead we have `Robur's blogMirageVPN and OpenVPN` (I noticed before, but forgot about it). I'll look into the former.