robur/builder-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Endpoint for builder exec asn.1 data #10

Merged
reynir merged 4 commits from download-full into main 2025-01-15 13:23:33 +00:00
Conversation 3 Commits 4 Files changed 4 +70 -12
reynir commented 2025-01-15 08:57:48 +00:00
Owner
Copy link

This allows us to download the builder "exec" data. As in the builder-db command there is a loss of precision in timestamps for console log output.

I tested this on a local builder-web instance with a solo5 build. I could correctly get the job information, console output and for the artifacts the main binary had the correct checksum \o/

This closes #13.

This allows us to download the builder "exec" data. As in the builder-db command there is a loss of precision in timestamps for console log output. I tested this on a local builder-web instance with a solo5 build. I could correctly get the job information, console output and for the artifacts the main binary had the correct checksum \o/ This closes #13.
reynir added 2 commits 2025-01-15 08:57:49 +00:00
hannes reviewed 2025-01-15 10:48:53 +00:00
lib/model.ml Outdated
@ -526,0 +531,4 @@
match List.rev lines with
| "" :: lines -> List.rev lines
| _ -> lines
in
hannes commented 2025-01-15 10:48:53 +00:00
Owner
Copy link

this looks a bit hackish -- do we really need it? Is it done elsewhere as well? How comes we get an empty line in the beginning?

this looks a bit hackish -- do we really need it? Is it done elsewhere as well? How comes we get an empty line in the beginning?
reynir commented 2025-01-15 12:18:08 +00:00
Author
Owner
Copy link

I copied the code from bin/builder_db_app.ml. I don't remember why we remove the last empty line. I agree that the whole function looks a bit sloppy. I will try to improve the code.

I copied the code from `bin/builder_db_app.ml`. I don't remember why we remove the last empty line. I agree that the whole function looks a bit sloppy. I will try to improve the code.
reynir commented 2025-01-15 12:39:26 +00:00
Author
Owner
Copy link

I now remember. It's because there's a \n at the end of the file, and this then breaks the timestamp parsing code later after we've split on \n.

I'll reiterate once again.

I now remember. It's because there's a `\n` at the end of the file, and this then breaks the timestamp parsing code later after we've split on `\n`. I'll reiterate once again.
reynir commented 2025-01-15 12:46:48 +00:00
Author
Owner
Copy link

I made the code a bit more robust against unexpected lines (which are then logged unless it's the empty string). I think it's good to merge now.

I made the code a bit more robust against unexpected lines (which are then logged unless it's the empty string). I think it's good to merge now.
reynir added 1 commit 2025-01-15 12:36:53 +00:00
reynir added 1 commit 2025-01-15 12:44:38 +00:00 
If a line somehow has an unexpected shape we log a warning and omit it.
reynir merged commit 879ecb6272 into main 2025-01-15 13:23:33 +00:00
reynir deleted branch download-full 2025-01-15 13:23:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/builder-web#10
No description provided.
Delete branch "download-full"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?