robur/builder-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Work around dream-encoding footgun #13

Merged
reynir merged 1 commit from fix-dream-encode into main 2025-01-24 13:21:18 +00:00
Conversation 0 Commits 1 Files changed 2 +14 -2
reynir commented 2025-01-24 13:00:46 +00:00
Owner
Copy link

Dream-encoding adds a Transfer-Encoding header to a response. If that response is an error code it will go through the error handler which may change the response - but the new response does not go through the dream-encoding middleware! This means we may rewrite the response with a plaintext message but still have the Transfer-Encoding header! This makes clients very unhappy.

I opened an issue in dream-encoding about this footgun: https://github.com/tmattio/dream-encoding/issues/6

Fixes #15

Dream-encoding adds a Transfer-Encoding header to a response. If that response is an error code it will go through the error handler which may change the response - but the new response *does not* go through the dream-encoding middleware! This means we may rewrite the response with a plaintext message but still have the Transfer-Encoding header! This makes clients very unhappy. I opened an issue in dream-encoding about this footgun: https://github.com/tmattio/dream-encoding/issues/6 Fixes #15
reynir added 1 commit 2025-01-24 13:00:47 +00:00 
Dream-encoding adds a Transfer-Encoding header to a response. If that
response is an error code it will go through the error handler which may
change the response - but the new response *does not* go through the
dream-encoding middleware! This means we may rewrite the response with a
plaintext message but still have the Transfer-Encoding header! This
makes clients very unhappy.
reynir merged commit 49ca776d33 into main 2025-01-24 13:21:18 +00:00
reynir deleted branch fix-dream-encode 2025-01-24 13:21:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/builder-web#13
No description provided.
Delete branch "fix-dream-encode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?