robur/cachet
4
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add the lwt support of cachet #1

Merged
dinosaure merged 1 commit from lwt into main 2024-12-11 10:49:50 +00:00
Conversation 0 Commits 1 Files changed 6 +181
dinosaure commented 2024-11-26 16:02:18 +00:00
Owner
Copy link

/cc @reynir WDYT?

/cc @reynir WDYT?
dinosaure added 1 commit 2024-11-26 16:02:19 +00:00
dinosaure reviewed 2024-11-26 16:03:33 +00:00
lib-lwt/cachet_lwt.ml
@ -0,0 +33,4 @@
get_uint8 t (logical_address + idx) >>= fun v ->
Bytes.set_uint8 buf (dst_off + idx) v;
go (succ idx)
end
dinosaure commented 2024-11-26 16:03:33 +00:00
Author
Owner
Copy link

Seems a perf killer but it's not. The bind operator on lwt is not a cooperative point, so if we look about the load function, we do an Lwt.pause only if we require to do a map. Otherwise, lwt will try to go as far as it can.

Seems a perf killer but it's not. The bind operator on lwt is not a cooperative point, so if we look about the `load` function, we do an `Lwt.pause` only if we require to do a `map`. Otherwise, lwt will try to go as far as it can.
dinosaure merged commit 46d4779f4a into main 2024-12-11 10:49:50 +00:00
dinosaure deleted branch lwt 2024-12-11 10:49:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/cachet#1
No description provided.
Delete branch "lwt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?