Partially fix tests

reynir commented

2024-10-25 09:05:43 +00:00

Owner

Since mgit is not a public executable it will not be present in $PATH - so we must use %{exe:...} over %{bin:...}.

The fix is partial because the (enabled_if ...) stanza doesn't work correctly for me at least. To fix it I tried the following without success...

Error: This value must be either true or false
File "test/dune", line 19, characters 13-31:
19 |  (enabled_if {%read:git-daemon})
                  ^^^^^^^^^^^^^^^^^^

Since mgit is not a public executable it will not be present in $PATH - so we must use %{exe:...} over %{bin:...}. The fix is partial because the (enabled_if ...) stanza doesn't work correctly for me at least. To fix it I tried the following without success... ``` Error: This value must be either true or false File "test/dune", line 19, characters 13-31: 19 | (enabled_if {%read:git-daemon}) ^^^^^^^^^^^^^^^^^^ ```

reynir added 1 commit 2024-10-25 09:05:43 +00:00

Partially fix tests 248a6cdde9

Since mgit is not a public executable it will not be present in $PATH -
so we must use %{exe:...} over %{bin:...}.

The fix is partial because the (enabled_if ...) stanza doesn't work
correctly for me at least.

reynir commented

2024-10-25 09:07:33 +00:00

Author

Owner

Oh! I see, it's %{read:...} not {%read:...}! But I still get an error:

File "test/dune", line 12, characters 13-31:
12 |  (enabled_if %{read:git-daemon})
                  ^^^^^^^^^^^^^^^^^^
Error: %{read:..} isn't allowed in this position.

Oh! I see, it's `%{read:...}` not `{%read:...}`! But I still get an error: ``` File "test/dune", line 12, characters 13-31: 12 | (enabled_if %{read:git-daemon}) ^^^^^^^^^^^^^^^^^^ Error: %{read:..} isn't allowed in this position. ```

reynir commented

2024-10-25 09:19:39 +00:00

Author

Owner

I tried as well to move git_daemon_exists.ml to a subdirectory as suggested here without luck https://dune.readthedocs.io/en/stable/concepts/variables.html#:~:text=The%20reason%20you,creates%20a%20cycle.

reynir commented

2024-10-25 09:23:49 +00:00

Author

Owner

So, the existing (enabled_if ...) stanza basically disables the tests always :/ I opened an issue with dune because the documentation seems to suggest it's possible to use (enabled_if %{read:git_daemon_exists}), but I can't find a configuration where it doesn't complain about %{read:..} not being allowed in this position.

https://github.com/ocaml/dune/issues/11042

So, the existing `(enabled_if ...)` stanza basically disables the tests **always** :/ I opened an issue with dune because the documentation seems to suggest it's possible to use `(enabled_if %{read:git_daemon_exists})`, but I can't find a configuration where it doesn't complain about `%{read:..}` not being allowed in this position. https://github.com/ocaml/dune/issues/11042