robur/git-kv
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

of_octets: create ring buffer earlier to avoid missing data #5

Merged
reynir merged 1 commit from fix-of-octets into main 2024-11-28 10:16:34 +00:00
Conversation 1 Commits 1 Files changed 1 +3 -3
hannes commented 2024-11-20 09:34:29 +00:00
Owner
Copy link

This fixes robur/opam-mirror#23

The issue is that at the moment, in opam-mirror we use a single element Lwt_stream. And in of_octets every read creates a fresh ring buffer, discarding the previously read data.

This fixes https://git.robur.coop/robur/opam-mirror/issues/23 The issue is that at the moment, in opam-mirror we use a single element Lwt_stream. And in of_octets every `read` creates a fresh ring buffer, discarding the previously read data.
hannes added 1 commit 2024-11-20 09:34:30 +00:00
reynir approved these changes 2024-11-20 09:45:29 +00:00
dinosaure approved these changes 2024-11-20 10:16:19 +00:00
dinosaure left a comment
Owner
Copy link

Nice catch!

Nice catch!
hannes commented 2024-11-20 10:22:30 +00:00
Author
Owner
Copy link

still remaining is an issue that git-kv restore takes ~30 minutes for opam-repository on my laptop... I'd hope we can get a 100x speedup somehow ;)

still remaining is an issue that git-kv restore takes ~30 minutes for opam-repository on my laptop... I'd hope we can get a 100x speedup somehow ;)
reynir merged commit 992127f2bd into main 2024-11-28 10:16:34 +00:00
reynir deleted branch fix-of-octets 2024-11-28 10:16:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
reynir
dinosaure
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/git-kv#5
No description provided.
Delete branch "fix-of-octets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?