robur/git-kv
4
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

of_octets: create ring buffer earlier to avoid missing data #5

Open
hannes wants to merge 1 commit from fix-of-octets into main
pull from: fix-of-octets
merge into: robur:main
Conversation 1 Commits 1 Files changed 1 +3 -3
hannes commented 2024-11-20 09:34:29 +00:00
Owner
Copy link

This fixes robur/opam-mirror#23

The issue is that at the moment, in opam-mirror we use a single element Lwt_stream. And in of_octets every read creates a fresh ring buffer, discarding the previously read data.

This fixes https://git.robur.coop/robur/opam-mirror/issues/23 The issue is that at the moment, in opam-mirror we use a single element Lwt_stream. And in of_octets every `read` creates a fresh ring buffer, discarding the previously read data.
hannes added 1 commit 2024-11-20 09:34:30 +00:00
reynir approved these changes 2024-11-20 09:45:29 +00:00
dinosaure approved these changes 2024-11-20 10:16:19 +00:00
dinosaure left a comment
Owner
Copy link

Nice catch!

Nice catch!
hannes commented 2024-11-20 10:22:30 +00:00
Author
Owner
Copy link

still remaining is an issue that git-kv restore takes ~30 minutes for opam-repository on my laptop... I'd hope we can get a 100x speedup somehow ;)

still remaining is an issue that git-kv restore takes ~30 minutes for opam-repository on my laptop... I'd hope we can get a 100x speedup somehow ;)
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix-of-octets:fix-of-octets
git checkout fix-of-octets

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff fix-of-octets
git checkout fix-of-octets
git rebase main
git checkout main
git merge --ff-only fix-of-octets
git checkout fix-of-octets
git rebase main
git checkout main
git merge --no-ff fix-of-octets
git checkout main
git merge --squash fix-of-octets
git checkout main
git merge --ff-only fix-of-octets
git checkout main
git merge fix-of-octets
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
reynir
dinosaure
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/git-kv#5
No description provided.
Delete branch "fix-of-octets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?