robur/git-kv
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Adjust Git_kv.commit to report staging status #8

Merged
hannes merged 1 commit from add-commit into main 2024-11-28 12:48:38 +00:00
Conversation 3 Commits 1 Files changed 2 +11 -3
reynir commented 2024-11-28 11:37:39 +00:00
Owner
Copy link

The implementation is a bit too naïve and will report the commit dirty even when there are no staged changes. It only detects if we're inside a change_and_push.

The implementation is a bit too naïve and will report the commit dirty even when there are no staged changes. It only detects if we're inside a `change_and_push`.
reynir added 1 commit 2024-11-28 11:37:40 +00:00 
The implementation is a bit too naïve and will report the commit dirty
even when there are no staged changes. It only detects if we're inside a
`change_and_push`.
hannes commented 2024-11-28 12:40:37 +00:00
Owner
Copy link

We can as well just say it's None within a change_and_push!?

We can as well just say it's None within a change_and_push!?
hannes commented 2024-11-28 12:41:21 +00:00
Owner
Copy link

But I'm fine with this proposal as well.

But I'm fine with this proposal as well.
reynir commented 2024-11-28 12:42:15 +00:00
Author
Owner
Copy link

Sure, I think None is fine too. We can refine later if we find it desirable.

Sure, I think `None` is fine too. We can refine later if we find it desirable.
hannes merged commit f5281fbcb1 into main 2024-11-28 12:48:38 +00:00
hannes deleted branch add-commit 2024-11-28 12:48:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/git-kv#8
No description provided.
Delete branch "add-commit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?