robur/opam-mirror
4
0
Fork 0
Code Issues 6 Pull requests 2 Projects Releases Packages Wiki Activity Actions

use git-kv 0.0.5+ API for to/of_octets #17

Merged
hannes merged 1 commit from git-kv-05 into main 2024-11-08 14:41:13 +00:00
Conversation 1 Commits 1 Files changed 2 +6 -3
hannes commented 2024-11-08 14:31:23 +00:00
Owner
Copy link
No description provided.
hannes added 1 commit 2024-11-08 14:31:24 +00:00
hannes force-pushed git-kv-05 from 926d3db53d to 68d2ec8e98 2024-11-08 14:32:00 +00:00 Compare
reynir approved these changes 2024-11-08 14:34:46 +00:00
reynir left a comment
Owner
Copy link

Nice! Thanks

Nice! Thanks
mirage/unikernel.ml
@ -916,7 +918,8 @@ stamp: %S
Logs.warn (fun m -> m "failed to read git state: %a" Cache.pp_error e);
Lwt.return (Error ())
| Ok Some data ->
Git_kv.of_octets git_ctx ~remote data >|= function
reynir commented 2024-11-08 14:34:36 +00:00
Owner
Copy link

It would be nice to also stream from cache - but I have not figured out a nice api for that in oneffs. The problem is the checksum is over the whole data, and we can't verify it until we've read it all. I'm not sure it's desirable to stream the whole data and then find out it's corrupt /o\

It would be nice to also stream from cache - but I have not figured out a nice api for that in oneffs. The problem is the checksum is over the whole data, and we can't verify it until we've read it all. I'm not sure it's desirable to stream the whole data and then find out it's corrupt /o\
reynir marked this conversation as resolved
hannes commented 2024-11-08 14:41:06 +00:00
Author
Owner
Copy link

That is a valid concern, let's discuss it in the oneffs repo / PR!?

That is a valid concern, let's discuss it in the oneffs repo / PR!?
hannes merged commit 921ee6b684 into main 2024-11-08 14:41:13 +00:00
hannes deleted branch git-kv-05 2024-11-08 14:41:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
reynir
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/opam-mirror#17
No description provided.
Delete branch "git-kv-05"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?