robur/opam-mirror
4
0
Fork 0
Code Issues 6 Pull requests 2 Projects Releases Packages Wiki Activity Actions

update to mirage 4.8 #4

Merged
hannes merged 1 commit from mirage-48 into main 2024-10-16 08:40:11 +00:00
Conversation 1 Commits 1 Files changed 2 +36 -91
hannes commented 2024-10-11 11:32:08 +00:00
Owner
Copy link
No description provided.
hannes added 1 commit 2024-10-11 11:32:08 +00:00
dinosaure reviewed 2024-10-15 09:15:28 +00:00
mirage/config.ml
@ -18,4 +4,0 @@
Runtime_arg.create ~pos:__POS__
{|let open Cmdliner in
let doc = Arg.info ~doc:"The private SSH password." [ "ssh-password" ] in
Arg.(value & opt (some string) None doc)|}
dinosaure commented 2024-10-15 09:15:28 +00:00
Owner
Copy link

How you can pass ssh-key and ssh-password then to the unikernel? I actually needs git_ssh for my usage.

How you can pass `ssh-key` and `ssh-password` then to the unikernel? I actually needs `git_ssh` for my usage.
hannes commented 2024-10-15 10:31:04 +00:00
Author
Owner
Copy link

In general, you don't and shouldn't ;) the command line arguments are private to the ssh/git device -- why would you need them elsewhere?

As a hack, you can inspect the value of Mirage_runtime.runtime_args () and take a look inside. But I really encourage that we disentangle / find a path on how you don't need to have ssh-key and ssh-password in your unikernel.

Another option is to have functions providing these values in the Git_mirage.

In general, you don't and shouldn't ;) the command line arguments are private to the ssh/git device -- why would you need them elsewhere? As a hack, you can inspect the value of `Mirage_runtime.runtime_args ()` and take a look inside. But I really encourage that we disentangle / find a path on how you don't need to have `ssh-key` and `ssh-password` in your unikernel. Another option is to have functions providing these values in the Git_mirage.
dinosaure commented 2024-10-15 11:54:13 +00:00
Owner
Copy link

Hmmhmm, I need to test the unikernel if I'm still able to synchronize the repo from a Git repository via SSH. As far as I understand, I should be able to do that.

Hmmhmm, I need to test the unikernel if I'm still able to synchronize the repo from a Git repository via SSH. As far as I understand, I should be able to do that.
hannes commented 2024-10-15 13:08:42 +00:00
Author
Owner
Copy link

Maybe not the best thing right now (let's fix that), but we have:

NETWORK OPTIONS
...
       --ssh-authenticator=SSH-AUTHENTICATOR
           SSH authenticator.

       --ssh-key=KEY
           Private SSH key (rsa:<seed> or ed25519:<b64-key>).

       --ssh-password=PASSWORD
           Private SSH password.

       --tls-authenticator=TLS-AUTHENTICATOR
           TLS authenticator.

We may move the DNS into a custom section, the HE into a custom section, and also the higher level (SSH/TLS/GIT) options into a custom section, and leave NETWORK for everything up to IPv4/IPv6.

Maybe not the best thing right now (let's fix that), but we have: ``` NETWORK OPTIONS ... --ssh-authenticator=SSH-AUTHENTICATOR SSH authenticator. --ssh-key=KEY Private SSH key (rsa:<seed> or ed25519:<b64-key>). --ssh-password=PASSWORD Private SSH password. --tls-authenticator=TLS-AUTHENTICATOR TLS authenticator. ``` We may move the DNS into a custom section, the HE into a custom section, and also the higher level (SSH/TLS/GIT) options into a custom section, and leave NETWORK for everything up to IPv4/IPv6.
hannes merged commit 9ada5c4a94 into main 2024-10-16 08:40:11 +00:00
hannes deleted branch mirage-48 2024-10-16 08:40:17 +00:00
hannes commented 2024-10-16 08:40:31 +00:00
Author
Owner
Copy link

merged after brief discussion with @reynir

merged after brief discussion with @reynir
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: robur/opam-mirror#4
No description provided.
Delete branch "mirage-48"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?