Hannes Mehnert hannes

1 follower · 0 following

• Joined on 2024-08-21

Repositories

1

Projects Packages Public activity Starred repositories

hannes commented on pull request robur/builder-web#10 2025-01-15 10:48:53 +00:00

Endpoint for builder exec asn.1 data

this looks a bit hackish -- do we really need it? Is it done elsewhere as well? How comes we get an empty line in the beginning?

hannes commented on pull request robur/builder-web#9 2025-01-09 17:30:52 +00:00

Use custom labels for the diffs

looks fine to me, I learned that diff has the option --label today.

hannes commented on pull request robur/builder-web#8 2025-01-08 16:00:14 +00:00

diff view: translate \n to <br>

I pushed the pre.

hannes pushed to fix at robur/builder-web 2025-01-08 16:00:08 +00:00

e26af2dfdf as suggested by @reynir, use a pre

hannes created pull request robur/builder-web#8 2025-01-08 14:35:11 +00:00

diff view: translate \n to <br>

hannes created branch fix in robur/builder-web 2025-01-08 14:34:48 +00:00

hannes pushed to fix at robur/builder-web 2025-01-08 14:34:48 +00:00

0a025adaae diff view: translate \n to <br>

hannes commented on pull request robur/builder-web#7 2025-01-08 12:05:03 +00:00

Compute and present the opam file differences as a unified diff

I pushed b966836 -- does that solve your concerns?

hannes pushed to opam-diff-as-diff at robur/builder-web 2025-01-08 12:04:46 +00:00

b9668365cd use Bos.OS.File.with_tmp_oc instead to cleanup files immediately

hannes commented on pull request robur/builder-web#7 2025-01-08 11:39:34 +00:00

Compute and present the opam file differences as a unified diff

Indeed.

hannes commented on pull request robur/builder-web#7 2025-01-08 11:39:13 +00:00

Compute and present the opam file differences as a unified diff

Yes, you're right. I'll adapt.

hannes commented on pull request robur/builder-web#7 2025-01-08 11:38:56 +00:00

Compute and present the opam file differences as a unified diff

in my experience, using the "with_preserved_format" is good -- apart from potentially dangling comments (in the last line). I also think a comment is worth it. Of course we can leave the opam…

hannes pushed to opam-diff-as-diff at robur/builder-web 2025-01-07 12:49:40 +00:00

420d049ff0 remove more unneeded code

hannes pushed to opam-diff-as-diff at robur/builder-web 2025-01-07 12:24:49 +00:00

f20227cfea remove more unneeded code

hannes created pull request robur/builder-web#7 2025-01-07 12:17:57 +00:00

Compute and present the opam file differences as a unified diff

hannes created branch opam-diff-as-diff in robur/builder-web 2025-01-07 12:17:33 +00:00

hannes pushed to opam-diff-as-diff at robur/builder-web 2025-01-07 12:17:33 +00:00

8c29161144 Compute and present the opam file differences as a unified diff

hannes commented on pull request robur/builder-web#6 2025-01-06 17:09:00 +00:00

Make json structure uniform

I scheduled a build (ssh builder@shell.robur.coop -> ssh poudriere -> builder-client execute builder-web), and deployed it (ssh builder_web -> pkg update && pkg upgrade -> service builder_web…

hannes created pull request robur/cachet#6 2025-01-06 17:03:30 +00:00

add x-maintenance-intent field to the opam file

hannes created branch add-main in robur/cachet 2025-01-06 17:03:12 +00:00